Add register form, missing proper feedback on error or success

src/store/postulantAdd.ts

@@ -0,0 +1,39 @@
+import { PayloadAction, createSlice, createEntityAdapter } from "@reduxjs/toolkit"
+
+import { StateRequest, elementAddFetch } from "./utils"
+import { Postulant } from "../services/postulants"
+import { postulantAdd } from "../services/postulantsAccessors"
+
+const postulantAdapter = createEntityAdapter<Postulant>()
+
+const postulantAddSlice = createSlice({
+    name: "addPostulant",
+    initialState: postulantAdapter.getInitialState({
+        readyStatus: "idle",
+    } as StateRequest),
+    reducers: {
+        getRequesting: (state) => {
+            state.readyStatus = "request"
+        },
+        getSuccess: (state, { payload }: PayloadAction<Postulant>) => {
+            state.readyStatus = "success"
+            postulantAdapter.addOne(state, payload)
+        },
+        getFailure: (state, { payload }: PayloadAction<string>) => {
+            state.readyStatus = "failure"
+            state.error = payload
+        },
+    },
+})
+
+export default postulantAddSlice.reducer
+export const { getRequesting, getSuccess, getFailure } = postulantAddSlice.actions
+
+export const fetchPostulantAdd = elementAddFetch(
+    postulantAdd,
+    getRequesting,
+    getSuccess,
+    getFailure,
+    () => null,
+    () => null
+)

src/store/preVolunteerAdd.ts

@@ -1,39 +0,0 @@
-import { PayloadAction, createSlice, createEntityAdapter } from "@reduxjs/toolkit"
-
-import { StateRequest, elementAddFetch } from "./utils"
-import { PreVolunteer } from "../services/preVolunteers"
-import { preVolunteerAdd } from "../services/preVolunteersAccessors"
-
-const preVolunteerAdapter = createEntityAdapter<PreVolunteer>()
-
-const preVolunteerAddSlice = createSlice({
-    name: "addPreVolunteer",
-    initialState: preVolunteerAdapter.getInitialState({
-        readyStatus: "idle",
-    } as StateRequest),
-    reducers: {
-        getRequesting: (state) => {
-            state.readyStatus = "request"
-        },
-        getSuccess: (state, { payload }: PayloadAction<PreVolunteer>) => {
-            state.readyStatus = "success"
-            preVolunteerAdapter.addOne(state, payload)
-        },
-        getFailure: (state, { payload }: PayloadAction<string>) => {
-            state.readyStatus = "failure"
-            state.error = payload
-        },
-    },
-})
-
-export default preVolunteerAddSlice.reducer
-export const { getRequesting, getSuccess, getFailure } = preVolunteerAddSlice.actions
-
-export const fetchPreVolunteerAdd = elementAddFetch(
-    preVolunteerAdd,
-    getRequesting,
-    getSuccess,
-    getFailure,
-    () => null,
-    () => null
-)

src/store/preVolunteerCount.ts

@@ -1,46 +0,0 @@
-import { PayloadAction, createSlice } from "@reduxjs/toolkit"
-
-import { StateRequest, toastError, elementValueFetch } from "./utils"
-import { preVolunteerCountGet } from "../services/preVolunteersAccessors"
-import { AppThunk, AppState } from "."
-
-export const initialState: StateRequest & { value?: number } = { readyStatus: "idle" }
-
-const preVolunteerCount = createSlice({
-    name: "preVolunteerCount",
-    initialState,
-    reducers: {
-        getRequesting: (state) => {
-            state.readyStatus = "request"
-        },
-        getSuccess: (state, { payload }: PayloadAction<number>) => {
-            state.readyStatus = "success"
-            state.value = payload
-        },
-        getFailure: (state, { payload }: PayloadAction<string>) => {
-            state.readyStatus = "failure"
-            state.error = payload
-        },
-    },
-})
-
-export default preVolunteerCount.reducer
-export const { getRequesting, getSuccess, getFailure } = preVolunteerCount.actions
-
-export const fetchPreVolunteerCount = elementValueFetch(
-    preVolunteerCountGet,
-    getRequesting,
-    getSuccess,
-    getFailure,
-    (error: Error) =>
-        toastError(`Erreur lors du chargement des bénévoles potentiels: ${error.message}`)
-)
-
-const shouldFetchPreVolunteerCount = (state: AppState) =>
-    state.preVolunteerCount.readyStatus !== "success"
-
-export const fetchPreVolunteerCountIfNeed = (): AppThunk => (dispatch, getState) => {
-    if (shouldFetchPreVolunteerCount(getState())) return dispatch(fetchPreVolunteerCount())
-
-    return null
-}

src/store/rootReducer.ts

@@ -4,12 +4,11 @@ import { connectRouter } from "connected-react-router"
 import auth from "./auth"
 import gameList from "./gameList"
 import announcementList from "./announcementList"
-import preVolunteerAdd from "./preVolunteerAdd"
-import preVolunteerCount from "./preVolunteerCount"
+import postulantAdd from "./postulantAdd"
 import teamList from "./teamList"
 import ui from "./ui"
 import volunteer from "./volunteer"
-import volunteerAdd from "./volunteerAdd"
+import volunteerAdd from "./volunteerPartialAdd"
 import volunteerList from "./volunteerList"
 import volunteerSet from "./volunteerSet"
 import volunteerLogin from "./volunteerLogin"
@@ -27,8 +26,7 @@ export default (history: History) => ({
     auth,
     gameList,
     announcementList,
-    preVolunteerAdd,
-    preVolunteerCount,
+    postulantAdd,
     teamList,
     ui,
     volunteer,

src/store/utils.ts

@@ -65,7 +65,7 @@ export function elementFetch<Element, ServiceInput extends Array<any>>(
 }
 
 export function elementAddFetch<Element>(
-    elementAddService: (volunteerWithoutId: Omit<Element, "id">) => Promise<{
+    elementAddService: (elementWithoutId: Omit<Element, "id">) => Promise<{
         data?: Element | undefined
         error?: Error | undefined
     }>,
@@ -74,12 +74,12 @@ export function elementAddFetch<Element>(
     getFailure: ActionCreatorWithPayload<string, string>,
     errorMessage?: (error: Error) => void,
     successMessage?: () => void
-): (volunteerWithoutId: Omit<Element, "id">) => AppThunk {
-    return (volunteerWithoutId: Omit<Element, "id">): AppThunk =>
+): (elementWithoutId: Omit<Element, "id">) => AppThunk {
+    return (elementWithoutId: Omit<Element, "id">): AppThunk =>
         async (dispatch) => {
             dispatch(getRequesting())
 
-            const { error, data } = await elementAddService(volunteerWithoutId)
+            const { error, data } = await elementAddService(elementWithoutId)
 
             if (error) {
                 dispatch(getFailure(error.message))
@@ -119,7 +119,7 @@ export function elementListFetch<Element, ServiceInput extends Array<any>>(
 }
 
 export function elementSet<Element>(
-    elementSetService: (volunteer: Element) => Promise<{
+    elementSetService: (element: Element) => Promise<{
         data?: Element | undefined
         error?: Error | undefined
     }>,

src/store/volunteerPartialAdd.ts

@@ -1,12 +1,12 @@
 import { PayloadAction, createSlice, createEntityAdapter } from "@reduxjs/toolkit"
 
-import { StateRequest, toastError, toastSuccess, elementAddFetch } from "./utils"
+import { StateRequest, elementAddFetch } from "./utils"
 import { Volunteer } from "../services/volunteers"
-import { volunteerAdd } from "../services/volunteersAccessors"
+import { volunteerPartialAdd } from "../services/volunteersAccessors"
 
 const volunteerAdapter = createEntityAdapter<Volunteer>()
 
-const volunteerAddSlice = createSlice({
+const volunteerPartialAddSlice = createSlice({
     name: "addVolunteer",
     initialState: volunteerAdapter.getInitialState({
         readyStatus: "idle",
@@ -26,14 +26,14 @@ const volunteerAddSlice = createSlice({
     },
 })
 
-export default volunteerAddSlice.reducer
-export const { getRequesting, getSuccess, getFailure } = volunteerAddSlice.actions
+export default volunteerPartialAddSlice.reducer
+export const { getRequesting, getSuccess, getFailure } = volunteerPartialAddSlice.actions
 
-export const fetchVolunteerAdd = elementAddFetch(
-    volunteerAdd,
+export const fetchVolunteerPartialAdd = elementAddFetch(
+    volunteerPartialAdd,
     getRequesting,
     getSuccess,
     getFailure,
-    (error: Error) => toastError(`Erreur lors de l'ajout d'un bénévole: ${error.message}`),
-    () => toastSuccess("Volunteer ajoutée !")
+    () => null,
+    () => null
 )